[
https://issues.apache.org/jira/browse/LUCENE-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067097#comment-13067097
]
Michael McCandless commented on LUCENE-2795:
--------------------------------------------
Can you touch up the javadocs? Ie it's more general now (not just
linux), and "uses direct io" instead of "Linux's O_DIRECT flag", and
uses direct io for all merge input & output. Make it clear that this
is a general purpose dir impl...
NativeUnixndexOutput should be NativeUnixIndexOutput.
The createOutput function should also switch between normal vs direct,
depending on MERGE or READ?
I think we should have a default forced buffer size? The thing to
keep in mind is how many open inputs/outputs we will have during
merging, eg I think something like 5 or 8 files per merged segment
plus another 5 or 8 for the resulting merged segment, so up to 88 file
handles open. Maybe 256 KB default?
We shouldn't by default use the BII's buffer size: it's way too small
for direct IO. And then we should always use the forced buffer size
in this dir...
Tests pass for me on Fedora 13 linux! Next I'll try OS X.
> Genericize DirectIOLinuxDir -> UnixDir
> --------------------------------------
>
> Key: LUCENE-2795
> URL: https://issues.apache.org/jira/browse/LUCENE-2795
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/store
> Reporter: Michael McCandless
> Assignee: Varun Thacker
> Labels: gsoc2011, lucene-gsoc-11, mentor
> Attachments: LUCENE-2795.patch, LUCENE-2795.patch, LUCENE-2795.patch,
> LUCENE-2795.patch, LUCENE-2795.patch
>
>
> Today DirectIOLinuxDir is tricky/dangerous to use, because you only want to
> use it for indexWriter and not IndexReader (searching). It's a trap.
> But, once we do LUCENE-2793, we can make it fully general purpose because
> then a single native Dir impl can be used.
> I'd also like to make it generic to other Unices, if we can, so that it
> becomes UnixDirectory.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
