Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r205124848
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DeeplyNestedChildDocTransformer.java
---
@@ -190,8 +179,18 @@ private String getLastPath(String path) {
return path.substring(path.lastIndexOf(PATH_SEP_CHAR.charAt(0)) + 1);
}
- private String trimSuffixFromPaths(String path) {
- return path.replaceAll("#\\d|#", "");
+ private String trimIfSingleDoc(String path) {
--- End diff --
Oh gotcha -- sure. It does complicate an explanation of what that String
is, as it won't simply be a label, but that's okay. Please add comments where
we declare the field to explain this stuff. (e.g.. what the outer String is
(with example), what the intermediate string is (with 2 examples)).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
