[
https://issues.apache.org/jira/browse/SOLR-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man resolved SOLR-2573.
----------------------------
Resolution: Not A Problem
Fix Version/s: (was: 3.4)
Assignee: Hoss Man
I don't think we should make this change
It's true that applying this patch would allow tests that want to use the
default handler to work w/o explicitly asking for that handler, but it would
break all existing tests for users who have test configs with a requestHandler
defined named "standard" (which is not the default).
Users who want to specify a differnet default handler name in their tests can
continue to do what they have always done:
* explicitly set lrf.qtype="" in the setup of their test class
* specify a "qt"="" param when making a call to lrf.makeRequest() or req() in
the test methods
bq. some test classes may have to be adjusted too? (I don't know how they
currently work).
...
bq. assertQ(req("q","*:*","qt","standard")); //STANDARD DOESN'T EXIST ANYMORE
while we no longer suggest/recommend naming a requestHandler "standard" in the
example solrconfig.xml file, requestHandler's named "standard" do in fact exist
in many of the test configs
There are definitely improvements that can/should be made to the TestHarness
and the LocalRequestFactory (neither of which have really kept up with all the
changes in Solr over the years) but those improvements should be in the
direction of changing the APIs and eliminating the extra layer of "defaults" in
those classes that already exist in the SolrCore -- as long as we have those
test apis/defaults, the defaults need to remain the same for back compat.
> Standard handler assumed as default in test breaks subclassing tests
> --------------------------------------------------------------------
>
> Key: SOLR-2573
> URL: https://issues.apache.org/jira/browse/SOLR-2573
> Project: Solr
> Issue Type: Bug
> Affects Versions: 3.2
> Reporter: Gabriele Kahlout
> Assignee: Hoss Man
> Priority: Minor
> Attachments: SOLR-2573.patch
>
>
> 'standard' is still specified as default qtype in TestHarness and
> SolrTestCaseJ4, which makes tests that rely on the default fail.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
