[
https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547351#comment-16547351
]
Cao Manh Dat commented on SOLR-12297:
-------------------------------------
My idea for this ticket :
* Add Http2SolrClient.java
* A minimal test for Http2SolrClient based on BasicHttpSolrClient (this ensure
the consistency in behaviors between Http2SolrClient and HttpSolrClient)
* Enable Http2 in JettySolrRunner for *test environment* only.
By doing that we can slowly introduce more supports on Http2
* All the changes will be tested for a very long time before we switch from
Http to Http2
* Won't impact the current final build/release.
I attached a *nearly finished* patch for this ticket :
* Http2SolrClient's behaviors consistent with HttpSolrClient (include error
handling, V2Request, multipart request, queryParams)
* Add Http2SolrClientTest which mimic BasicHttpSolrClientTest
I wonder that should I keep continue working on this issue, or create another
one. Because my vision for this issue seems not match with others.
> Add Http2SolrClient, capable of HTTP/1.1, HTTP/2, and asynchronous requests.
> ----------------------------------------------------------------------------
>
> Key: SOLR-12297
> URL: https://issues.apache.org/jira/browse/SOLR-12297
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Major
> Attachments: SOLR-12297.patch, SOLR-12297.patch,
> starburst-ivy-fixes.patch
>
>
> Blocking or async support as well as HTTP2 compatible with multiplexing.
> Once it supports enough and is stable, replace internal usage, allowing
> async, and eventually move to HTTP2 connector and allow multiplexing. Could
> support HTTP1.1 and HTTP2 on different ports depending on state of the world
> then.
> The goal of the client itself is to work against HTTP1.1 or HTTP2 with
> minimal or no code path differences and the same for async requests (should
> initially work for both 1.1 and 2 and share majority of code).
> The client should also be able to replace HttpSolrClient and plug into the
> other clients the same way.
> I doubt it would make sense to keep ConcurrentUpdateSolrClient eventually
> though.
> I evaluated some clients and while there are a few options, I went with
> Jetty's HttpClient. It's more mature than Apache HttpClient's support (in 5
> beta) and we would have to update to a new API for Apache HttpClient anyway.
> Meanwhile, the Jetty guys have been very supportive of helping Solr with any
> issues and I like having the client and server from the same project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
