[
https://issues.apache.org/jira/browse/SOLR-12394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547039#comment-16547039
]
Christine Poerschke commented on SOLR-12394:
--------------------------------------------
+1 to removing unused code paths.
Wondering about what back-compatibility considerations apply here e.g.
* need the accessors stay around (as deprecated) for one 7.x version or all 7.x
versions?
* should we start warning in one version if someone still has the element in
their {{solr.xml}} and only in the next version would the
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.4.0/solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java#L278
style exceptions be thrown?
* is the code concerned too unused-and-never-used to not worry about orderly
removal so long as {{solr/CHANGES.txt}} clearly mentions that a {{solr.xml}}
update is needed?
> Remove managmentPath
> ---------------------
>
> Key: SOLR-12394
> URL: https://issues.apache.org/jira/browse/SOLR-12394
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Gus Heck
> Priority: Minor
> Attachments: SOLR-12394.patch
>
>
> NodeConfig has a property called managmentPath config which doesn't appear to
> serve any coherent function and is in fact documented in
> [https://lucene.apache.org/solr/guide/7_3/format-of-solr-xml.html] as:
> {quote}{{managementPath}}
> Currently non-operational.
> {quote}
> The code appears to have been added initially in SOLR-695, and that ticket
> appears to relate to an elimination of a special case for single core
> configurations. It seems that this may have been an attempt to support single
> cores that had no name (a legacy mode of operation I guess, but before my
> time) and yet still allow such single core setups to later have additional
> cores added?
> So this ticket is a suggestion that we remove this configuration that
> allegedly isn't working anyway, OR we make it work and give it good clear
> documentation in code and in the ref guide so that folks don't have to waste
> a lot of time figuring out what it does(n't do) to understand the code.
> Attaching patch to remove it.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
