: But I don't think this has been historically done (i.e. I bet >95% of : bug reports in CHANGES do not list the author if they did not : contribute to the patch).
i can't find it now, but i seem to recall a recent discussion specificly on the fact that we should do more to acknowledge people who take the time to submit "good" bug reports in CHANGES.txt, even if they don't actually contribute a patch. Even if that discussion was only in my head, i think it's a good idea moving forward. : I think we should try to be consistent about this (i.e. we either : should or shouldn't as a group). : So if we all want to start doing this, is it just for bug reports, or : for feature requests as well? I think it's anyone you feel has genuinely "contributed" ... if Adam files a vague bug report, and Bob basically has to start from scratch to track down what hte problem is and post a comment explaining how to reproduce, and committer Carl then writes up the test case and a fix, i don't think there's anythign wrong with crediting Bob but not Adam. Likewise if Adam files a feature request, but doesn't really flesh out how it should work, and then Bob posts a detailed design of what the semantics should be and what the API should look which Carl then implements, and Dave then comes along and gives a bunch of feedback on the patch and points out inconsistences that Carl fixes, then i think it's totally fair if Carl wants to give credit to both Bob and Dave (but not Adam) The key in both of those examples is to give credit to people who you feel genuinely contributed to a change (bug fix or feature) even if those contributions were not code. -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
