[
https://issues.apache.org/jira/browse/LUCENE-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519467#comment-16519467
]
Nicholas Knize commented on LUCENE-8364:
----------------------------------------
Thanks [~rcmuir] for taking the time to review the first iteration patch. And
for highlighting potential performance implications.
{quote}what is the goal of all the new abstractions?{quote}
At this point, its nothing more than organization, approachability,
maintainability of the existing code.
{quote}I don't think we should be building a geo library here{quote}
That's fine. If that's the general consensus I'll update the patch to remove
the abstractions and lock as much of this down as possible.
{quote}Maybe, it would be easier to split up the proposed changes so its easier
to review.{quote}
I think removing the abstractions for this first cut will achieve that?
> Refactor and clean up core geo api
> ----------------------------------
>
> Key: LUCENE-8364
> URL: https://issues.apache.org/jira/browse/LUCENE-8364
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Nicholas Knize
> Priority: Major
> Attachments: LUCENE-8364.patch
>
>
> The core geo API is quite disorganized and confusing. For example there is
> {{Polygon}} for creating an instance of polygon vertices and holes and
> {{Polygon2D}} for computing relations between points and polygons. There is
> also a {{PolygonPredicate}} and {{DistancePredicate}} in {{GeoUtils}} for
> computing point in polygon and point distance relations, respectively, and a
> {{GeoRelationUtils}} utility class which is no longer used for anything. This
> disorganization is due to the organic improvements of simple {{LatLonPoint}}
> indexing and search features and a little TLC is needed to clean up api to
> make it more approachable and easy to understand.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
