[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506274#comment-16506274
]
David Smiley commented on SOLR-12361:
-------------------------------------
New patch:
* removed overloaded getLuceneDocument(isInplaceUpdate) since we can simply
call IsInPlaceUpdate() internally
* Added "ignoreNestedDocs" flag to DocumentBuilder.toDocument() to toggle
wether it throws an exception or ignores them. Further,
AddUpdateCommand.getLuceneDocsIfNested() now checks this early and returns null
instead of throwing an exception later in this method.
I left the document equality issue for another time, commenting on SOLR-5265:
https://issues.apache.org/jira/browse/SOLR-5265?focusedCommentId=16506268&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16506268
I think this is ready. The tests pass, and precommit is running now. What do
you think [~moshebla]? How should I refer to you in CHANGES.txt?
> Change _childDocuments to Map
> -----------------------------
>
> Key: SOLR-12361
> URL: https://issues.apache.org/jira/browse/SOLR-12361
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: mosh
> Priority: Major
> Attachments: SOLR-12361.patch, SOLR-12361.patch, SOLR-12361.patch,
> SOLR-12361.patch
>
> Time Spent: 10h
> Remaining Estimate: 0h
>
> During the discussion on SOLR-12298, there was a proposal to change
> _childDocuments in SolrDocumentBase to a Map, to incorporate the relationship
> between the parent and its child documents.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
