Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r193789756
--- Diff:
solr/solrj/src/java/org/apache/solr/common/util/JsonRecordReader.java ---
@@ -438,18 +442,19 @@ void walkObject() throws IOException {
}
}
- private void addChildDoc2ParentDoc(Map<String, Object> record,
Map<String, Object> values) {
+ private void addChildDoc2ParentDoc(Map<String, Object> record,
Map<String, Object> values, String path) {
+ String trimmedPath = trimPath(path);
--- End diff --
I think "path" should be renamed "key", and the trimPath() should be done
by the caller, and not be called trimPath either for that matter -- it takes
the "leaf" or "suffix" part of the path, or perhaps you have an idea of a
better name.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
