Jan Høydahl created SOLR-12456:
----------------------------------

             Summary: Move some OverseerTaskProcessor and NodeLostTrigger 
logging to TRACE
                 Key: SOLR-12456
                 URL: https://issues.apache.org/jira/browse/SOLR-12456
             Project: Solr
          Issue Type: Improvement
      Security Level: Public (Default Security Level. Issues are Public)
          Components: logging
            Reporter: Jan Høydahl


When running Solr on DEBUG level logging (bin/solr start -c -v -f) there are 
some *very* chatty classes spitting out meaningless log lines every second. 
This typically looks like
{noformat}
2018-06-06 14:36:59.486 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor Got 0 tasks from work-queue : [[]]
2018-06-06 14:36:59.487 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor Cleaning up work-queue. #Running tasks: 0
2018-06-06 14:36:59.487 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor RunningTasks: []
2018-06-06 14:36:59.487 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor BlockedTasks: []
2018-06-06 14:36:59.488 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor CompletedTasks: []
2018-06-06 14:36:59.488 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor RunningZKTasks: []
2018-06-06 14:36:59.488 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskQueue Peeking for top 100 elements. ExcludeSet: []
2018-06-06 14:36:59.574 DEBUG (ScheduledTrigger-7-thread-3) [ ] 
o.a.s.c.a.NodeLostTrigger Running NodeLostTrigger: .auto_add_replicas with 
currently live nodes: 1
2018-06-06 14:37:00.575 DEBUG (ScheduledTrigger-7-thread-1) [ ] 
o.a.s.c.a.NodeLostTrigger Running NodeLostTrigger: .auto_add_replicas with 
currently live nodes: 1
2018-06-06 14:37:01.493 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor Got 0 tasks from work-queue : [[]]
2018-06-06 14:37:01.494 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor Cleaning up work-queue. #Running tasks: 0
2018-06-06 14:37:01.494 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor RunningTasks: []
2018-06-06 14:37:01.494 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor BlockedTasks: []
2018-06-06 14:37:01.494 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor CompletedTasks: []
2018-06-06 14:37:01.494 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskProcessor RunningZKTasks: []
2018-06-06 14:37:01.494 DEBUG 
(OverseerCollectionConfigSetProcessor-72072338763677696-192.168.127.248:8983_solr-n_0000000001)
 [ ] o.a.s.c.OverseerTaskQueue Peeking for top 100 elements. ExcludeSet: []
2018-06-06 14:37:01.577 DEBUG (ScheduledTrigger-7-thread-3) [ ] 
o.a.s.c.a.NodeLostTrigger Running NodeLostTrigger: .auto_add_replicas with 
currently live nodes: 1
2018-06-06 14:37:02.577 DEBUG (ScheduledTrigger-7-thread-1) [ ] 
o.a.s.c.a.NodeLostTrigger Running NodeLostTrigger: .auto_add_replicas with 
currently live nodes: 1
2018-0{noformat}
These spam the log making it harder to spot important stuff.

I propose to make these conditional and log on TRACE level (or not at all) if 
there is nothing to report, and on DEBUG level if there e.g. actually are tasks 
on the overseer queue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to