[
https://issues.apache.org/jira/browse/LUCENE-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499180#comment-16499180
]
David Smiley commented on LUCENE-8332:
--------------------------------------
This Yetus/QA report doesn't make sense to me. The QA build failed, apparently
due to some compilation issue:
{quote}
[javac] Compiling 35 source files to
/x1/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/lucene/build/suggest/classes/test
[javac]
/x1/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/lucene/suggest/src/test/org/apache/lucene/search/suggest/document/CompletionTokenStreamTest.java:34:
error: class TestConcatenateGraphFilter is public, should be declared in a
file named TestConcatenateGraphFilter.java
[javac] public class TestConcatenateGraphFilter extends
BaseTokenStreamTestCase {
[javac] ^
{quote}
But the patch *renames* CompletionTokenStreamTest.java to
TestConcatenateGraphFilter.java (and manually inspecting the patch reflects
this) so I don't see out this came to be. I hate to bother you [~steve_rowe]
but if you have any tips on diagnosing puzzling Yetus build failures then I'd
appreciate it.
I intend on committing the patch Monday, BTW.
> New ConcatenateGraphTokenStream (move/rename CompletionTokenStream)
> -------------------------------------------------------------------
>
> Key: LUCENE-8332
> URL: https://issues.apache.org/jira/browse/LUCENE-8332
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/analysis
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Attachments: LUCENE-8332.patch, LUCENE-8332.patch, LUCENE-8332.patch
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Lets move and rename the CompletionTokenStream in the suggest module into the
> analysis module renamed as ConcatenateGraphTokenStream. See comments in
> LUCENE-8323 leading to this idea. Such a TokenStream (or TokenFilter?) has
> several uses:
> * for the suggest module
> * by the SolrTextTagger for NER/ERD use cases – SOLR-12376
> * for doing complete match search efficiently
> It will need a factory – a TokenFilterFactory, even though we don't have a
> TokenFilter based subclass of TokenStream.
> It appears there is no back-compat concern in it suddenly disappearing from
> the suggest module as it's marked experimental and it only seems to be public
> now perhaps due to some technicality (it has package level constructors).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
