[
https://issues.apache.org/jira/browse/SOLR-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465327#comment-16465327
]
Mark Miller commented on SOLR-12313:
------------------------------------
bq. Okay, I see, the uncommitted changes check
Hmm, I think I still see it causes long delays when it should not sometimes. I
won't do anything here right away, but something needs to change.
> TestInjection#waitForInSyncWithLeader needs improvement.
> --------------------------------------------------------
>
> Key: SOLR-12313
> URL: https://issues.apache.org/jira/browse/SOLR-12313
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Priority: Major
>
> This really should have some doc for why it would be used.
> I also think it causes BasicDistributedZkTest to take forever for sometimes
> and perhaps other tests?
> I think checking for uncommitted data is probably a race condition and should
> be removed.
> Checking index versions should follow the rules that replication does - if
> the slave is higher than the leader, it's in sync, being equal is not
> required. If it's expected for a test it should be a specific test that
> fails. This just introduces massive delays.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
