[
https://issues.apache.org/jira/browse/SOLR-12304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463792#comment-16463792
]
Alessandro Benedetti commented on SOLR-12304:
---------------------------------------------
[~dsmiley] thanks for your comment.
Generally in Software Engineering I am a strong supporter of the KISS principle
so in short I agree with you, I would love to see both the handler and the
component gone, and only the Query Parser left as only entry point for More
Like This Lucene functionality.
Given that, let me analyse what the handler and the component are offering,
which the query parser does not.
This could generate few other Jira issues to complete before we remove the
handler and component :
1) *more advanced debug* - in my opinion is neglectable, the normal debug will
show the query parsed which will be more than enough to understand how the MLT
query was built.
2) *Interesting Terms* - which was the scope of this issue, also in this case I
do agree that getting the interesting terms out of a corpus of documents should
be a separate feature ( close to faceting than MLT).
getting the interesting terms out of the More Like This source document can be
done indirectly verifying the debug information for the query parsing
+1 to officially deprecate both the handler and component, those classes are
very coupled and not very readable anyway ( with no offese to any author)
This will also simplify the work I am doing refactoring the Lucene More Like
This ( https://issues.apache.org/jira/browse/SOLR-12299 )
> Interesting Terms parameter is ignored by MLT Component
> -------------------------------------------------------
>
> Key: SOLR-12304
> URL: https://issues.apache.org/jira/browse/SOLR-12304
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: MoreLikeThis
> Affects Versions: 7.2
> Reporter: Alessandro Benedetti
> Priority: Major
> Attachments: SOLR-12304.patch, SOLR-12304.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the More Like This component just ignores the mlt.InterestingTerms
> parameter ( which is usable by the MoreLikeThisHandler).
> Scope of this issue is to fix the bug and add related tests ( which will
> succeed after the fix )
> *N.B.* MoreLikeThisComponent and MoreLikeThisHandler are very coupled and the
> tests for the MoreLikeThisHandler are intersecting the MoreLikeThisComponent
> ones .
> It is out of scope for this issue any consideration or refactor of that.
> Other issues will follow.
> *N.B.* out of scope for this issue is the distributed case, which is much
> more complicated and requires much deeper investigations
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
