[
https://issues.apache.org/jira/browse/SOLR-12308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463314#comment-16463314
]
David Smiley commented on SOLR-12308:
-------------------------------------
Patch summary:
* CollectionsHandler: LISTALIASES: add aliasesManager.update()
* ZkStateReader AliasesManager: just clarified the loop (while -> for) and
clarified that if you get to after the loop then we always (not conditionally)
throw an exception.
* MiniSolrCloudCluster.deleteAllCollections now deletes all aliases too (just
a one-liner; very efficient)
* AliasIntegrationTest:
** tearDown: simplify to no longer explicitly delete aliases; no need
** testProperties: simplified some code at the end; no real change
** testModifyPropertiesV2: removed one call to sleepToAllowZkPropagation that
shouldn't be necessary anymore. I reviewed the other uses which should stay.
* CreateRoutedAliasTest:
** refactored away the need to have a httpClient field
** moved the cleanup logic to a doAfter where it ought to be. It needn't
explicitly delete aliases here since it'll now happen via
cluster.deleteAllCollections();
Tests pass.
[~gus_heck] could you please take a look?
> LISTALIASES should return up to date response
> ---------------------------------------------
>
> Key: SOLR-12308
> URL: https://issues.apache.org/jira/browse/SOLR-12308
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Attachments: SOLR-12308.patch
>
>
> The LISTALIASES command might return a stale response due to the default
> eventual consistency of reads of ZooKeeper. I think if someone calls this
> command (which generally won't be rapid-fire), they deserve an up to date
> response. This is easily done with a one-liner; patch forthcoming.
> Returning stale alias info is the only plausible explanation I have for why a
> recent CI failure for AliasesIntegrationTest.tearDown() failed to detect
> aliases to be deleted. It calls listAliases to know which aliases exist so it
> can then delete them 1st.
> [https://jenkins.thetaphi.de/job/Lucene-Solr-master-Solaris/1833/]
> tearDown then calls MiniSolrCloudCluster.deleteAllCollections() which
> interestingly grabs a ZkStateReader.createClusterStateWatchersAndUpdate()....
> perhaps this ought to delete all aliases _as well_ since, after all, if there
> were any aliases then well deleting all collections is bound to fail. Should
> I file a separate issue or just handle this together?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
