[ 
https://issues.apache.org/jira/browse/SOLR-12275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453958#comment-16453958
 ] 

David Smiley commented on SOLR-12275:
-------------------------------------

The primary change looks good to me.  There apparently was no use in 
FiltersQuery :)

In the test, you can use Java 7 try-with-resources for less verbose code. FWIW 
IntelliJ will both point this out and do it for you.

And:
{code:java}
      try {
        assertU(delI("12275"));
        assertU(commit());
      } catch(Throwable t) {
        log.error("ignoring exception occuring in compensation routine", t);
      }
{code}
can be replaced with simply {{clearIndex();}}

> {!filters} are cached wrong
> ---------------------------
>
>                 Key: SOLR-12275
>                 URL: https://issues.apache.org/jira/browse/SOLR-12275
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: query parsers
>    Affects Versions: 7.3
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>            Priority: Major
>             Fix For: 7.4, master (8.0)
>
>         Attachments: SOLR-12275.patch, SOLR-12275.patch
>
>
> As it [was 
> spotted|https://issues.apache.org/jira/browse/SOLR-9510?focusedCommentId=16452683&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16452683]
>  by [[email protected]], {{\{!filters}}} behaves wrong when cached. As a 
> workaround it's proposed to pass {{cache=false}} as a local parameter



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to