[
https://issues.apache.org/jira/browse/SOLR-12142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443543#comment-16443543
]
David Smiley commented on SOLR-12142:
-------------------------------------
I wasn't expecting this is in committable shape yet... I'll find out if this
actually works over in the SolrTextTagger tests which has a test that posts
plain text (not XML or JavaBin) to a custom RequestHandler. That's what
prompted this issue (and another).
https://github.com/OpenSextant/SolrTextTagger/blob/ab6951a1f77218f2b27ff00e9a13970fd70fffb3/src/test/java/org/opensextant/solrtexttagger/EmbeddedSolrNoSerializeTest.java#L106
BTW when I said "assuming BinaryRequestWriter().write is used? Then I guess
don't use it." I meant maybe then don't use this approach at all – no
RequestWriter, no anonymous inner class of ContentStreamBase.
> EmbeddedSolrServer should use req.getContentWriter
> ---------------------------------------------------
>
> Key: SOLR-12142
> URL: https://issues.apache.org/jira/browse/SOLR-12142
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: Noble Paul
> Priority: Major
> Fix For: 7.4
>
> Attachments: SOLR-12142.patch
>
>
> In SOLR-11380, SolrRequest.getContentWriter was introduced as a replacement
> for getContentStreams. However, EmbeddedSolrServer still calls
> getContentStreams, and so clients who need to send POST data to it cannot yet
> switch from the Deprecated API to the new API. The SolrTextTagger is an
> example of a project where one would want to do this.
> It seems EmbeddedSolrServer ought to check for getContentWriter and if
> present then convert it into a ContentStream somehow. For the time being,
> ESS needs to call both since both APIs exist.
> CC [~noble.paul]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
