[
https://issues.apache.org/jira/browse/SOLR-11865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427637#comment-16427637
]
David Smiley commented on SOLR-11865:
-------------------------------------
This is looking very good Bruno. You even hid InitializationException. I
think I can take it from here but would like some input. I can throw up
another patch. I've already tweaked some formatting locally (e.g. bad or wrong
indentation).
* Why make it possible for a subclass to change the _default_ values of
settings? I'm looking at the getters you added referring to some constants and
it seems needless. These are just defaults after all; can't you simply be
explicit if the default doesn't suit you?
* RE keepElevationPriority, I saw you added it to QueryElevationParams but
realized you're not actually using it as a _parameter_, you're using it as a
config file setting name (which we don't call parameters in Solr as it's
ambiguous). Therefore it goes to a constant in QEC.
** I want to ensure I understand this setting better. I did read the docs you
put on the constant definition. So it requires forceElevation. If this is
configured to false, will the sort order of the elevated documents be not only
at the top but then sorted by the sort parameter coming into Solr? And if true
it's in config-order? Maybe this could be named forceElevationWithConfigOrder?
This way it's name suggests a more clear relationship with forceElevation.
BTW I'm going to add a bit of docs to the ref guide (file
{{the-query-elevation-component.adoc}}) here.
> Refactor QueryElevationComponent to prepare query subset matching
> -----------------------------------------------------------------
>
> Key: SOLR-11865
> URL: https://issues.apache.org/jira/browse/SOLR-11865
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SearchComponents - other
> Affects Versions: master (8.0)
> Reporter: Bruno Roustant
> Priority: Minor
> Labels: QueryComponent
> Fix For: master (8.0)
>
> Attachments:
> 0001-Refactor-QueryElevationComponent-to-introduce-Elevat.patch,
> 0002-Refactor-QueryElevationComponent-after-review.patch,
> 0003-Remove-exception-handlers-and-refactor-getBoostDocs.patch,
> SOLR-11865.patch
>
>
> The goal is to prepare a second improvement to support query terms subset
> matching or query elevation rules.
> Before that, we need to refactor the QueryElevationComponent. We make it
> extendible. We introduce the ElevationProvider interface which will be
> implemented later in a second patch to support subset matching. The current
> full-query match policy becomes a default simple MapElevationProvider.
> - Add overridable methods to handle exceptions during the component
> initialization.
> - Add overridable methods to provide the default values for config properties.
> - No functional change beyond refactoring.
> - Adapt unit test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
