I'd like people to get credit for test fixes, whether in a new section or not. Cleaning up tests is enough of a thankless task as it stands, some recognition for attending to that is in order ;) CHANGES.txt is a good place for that. Besides, having a section of that may encourage people to take fixing tests more seriously.
On Thu, Apr 5, 2018 at 12:43 PM, Anshum Gupta <[email protected]> wrote: > I agree with Hoss about the fact that we should try and put things in better > suited section. 'Other changes' feels like an easy way out to just put > everything, but it makes it really difficult for end users/developers to > look at a release and find changes that might be of interest to them. > > I also think users are concerned/bothered about bug fixes to tests, and > considering we have a reasonable number of commits in just that category, it > calls for it's own section. It doesn't make any thing more confusing or hard > to maintain, instead only makes it easier for everyone looking at the > CHANGES.txt. > > Anshum > > > > > On Apr 5, 2018, at 12:21 PM, Jason Gerlowski <[email protected]> wrote: > > To toss my two cents in, I agree with Hoss's point generally. Burying > important things that users may care about in "Other Changes" makes > them harder to discover, and we should start double-checking ourselves > on that. > > But as for test-fix changes specifically, if the main purpose of > CHANGES.txt is to: > > be able to understand at a glance what important changes tye may care about > > > then I'm not sure test-fixes should be in CHANGES.txt at all. Very > few users are going to care about test bug fixes when evaluating > what's new in a Solr, or what they'll need to do to upgrade. The > added noise probably makes it harder for users to identify which > changes actually matter to them. > > Best, > > Jason > > On Thu, Apr 5, 2018 at 2:56 PM, Shawn Heisey <[email protected]> wrote: > > On 4/5/2018 12:38 PM, David Smiley wrote: > > This issues you listed are gray areas; I won't debate each with you. > I respect your opinion. I just don't see the value of a section for > *test* bug fixes. A user wants to know about the improvements, > features, and bug fixes (to a running Solr instance). Everything else > is just not as interesting to a user so goes in other, even though > technically it's a bug fix (to a test). > > > I see two viable solutions. One is a completely separate CHANGES file > for dev/test issues, the other is a new section in the existing file, so > that Other Changes isn't overrun as Hoss has noticed. > > It's my opinion, which I think aligns with what Hoss is saying, that the > fact that Other Changes is getting so much use (abuse?) is an indication > of one of two things, and quite possibly both: > > 1) The sections we have are insufficient for proper classification. > 2) We aren't putting issues in the right section. > > Thanks, > Shawn > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
