[
https://issues.apache.org/jira/browse/SOLR-12139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419108#comment-16419108
]
David Smiley commented on SOLR-12139:
-------------------------------------
Nice work Andrey. We'll see how this fairs in tests.
I could imagine that somehow for unforeseen reasons a case occurs where we
don't detect it's numeric and so we do the object comparison. And things like
Integer.equals are strict on the opposing type being the same class. That's a
bit strict for our liking here. But maybe not worry about that risk right now?
It's possibly fixable by the user requiring them to use constants of the
appropriate type (e.g. 1.0 vs 1). Any way, I'm good with the patch as is if it
passes tests.
> Support "eq" function for string fields
> ---------------------------------------
>
> Key: SOLR-12139
> URL: https://issues.apache.org/jira/browse/SOLR-12139
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
> Reporter: Andrey Kudryavtsev
> Assignee: Mikhail Khludnev
> Priority: Minor
> Attachments: SOLR-12139.patch, SOLR-12139.patch, SOLR-12139.patch,
> SOLR-12139.patch
>
>
> I just discovered that {{eq}} user function will work for numeric fields only.
> For string types it results in {{java.lang.UnsupportedOperationException}}
> What do you think if we will extend it to support at least some of string
> types as well?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
