[
https://issues.apache.org/jira/browse/SOLR-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415310#comment-16415310
]
Jan Høydahl commented on SOLR-12144:
------------------------------------
Patch attached:
* Default SOLR_LOG_PRESTART_ROTATION to false in bin/solr[.cmd]
* Changed comments in solr.in.\{sh|cmd} to indicate that you can enable
rotation if you use another log framework that do not handle rotation
* Added some text to the upgrade notes related to log4j2 so people who rely on
current prestart behaviour can adjust.
* All Java code in {{SolrCLI.UtilsTool}} is still in place
Now that GC log archival to logs/archived is disabled by default, Java will
continue to write to the existing GC log on restart, so skipping archival of GC
logs does not hurt anything?
Now that Console log archival to logs/archived is disabled by default, existing
console-log *will* be overwritten on restart, which is a potential side effect
of this patch.
Another option is to leave SOLR_LOG_PRESTART_ROTATION as true, but REM out only
the {{rotate_solr_logs}} part from bin/solr and instruct people to re-enable
that one line if they change log framework. WDYT?
> Remove SOLR_LOG_PRESTART_ROTATION and leverage log4j2
> ------------------------------------------------------
>
> Key: SOLR-12144
> URL: https://issues.apache.org/jira/browse/SOLR-12144
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
> Reporter: Varun Thacker
> Assignee: Jan Høydahl
> Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: SOLR-12144.patch, SOLR-12144.patch
>
>
> With log4j2 rotating the file on restart is as simple as adding a policy -
> OnStartupTriggeringPolicy
> So we can remove Solr logic which does the same and exposes it via
> SOLR_LOG_PRESTART_ROTATION .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
