[ 
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414215#comment-16414215
 ] 

Varun Thacker commented on SOLR-7887:
-------------------------------------

- Moved CHANGES entry from the Solr 7.3 section to 7.4 
- Fixed the CHANGES upgrade notes typos
- Changed references which were using log4j.properties to log4j2.xml
- Changed references which were using log4j.configuration to 
log4j.configurationFile
- Fixed ref guide references pointing to the old log4j.properties file
- The default log4j2.xml rotates log files at 32MB (instead of 4 ) and keeps 10 
log files ( instead of 7) with the patch
- Revert the log pattern to use solr.log.N instead of solr.N.log.gz
- In solr/contrib/prometheus-exporter/ivy.xml change 
dependency=log4j-slf4j-impl to use attribute compile and not test
- Revert cruft from JettySolrRunner
- log4j2.xml now uses the solr.log as the sys prop for fileName/filePattern 
attribute
- Fixed solr/server/scripts/cloud-scripts/log4j2.xml with the correct class 
pattern
- Fixed solr/solrj/src/test-files/log4j2.xml with the correct class pattern
- Fixed solr/contrib/ltr/src/test-files/log4j2.xml with the correct class 
pattern
- Fixed solr/test-framework/src/test-files/log4j2.xml with the correct class 
pattern

I'll commit this followup patch shortly

I need to make another pass at the commit and see if we need to address more 
issues and post an additional patch.

This is are still broken:
- configuring-logging.adoc references \{ivy-log4j-version} but I don't see the 
variable being set anywhere

TODO:
validate the command line flags : rotate_solr_logs , SOLR_LOG_PRESTART_ROTATION 
mentioned under "Permanent Logging Settings" 
http://lucene.apache.org/solr/guide/7_2/configuring-logging.html
Tomás had a comment on the reviewboard which we never addressed : "Right. And 
we already have lines for forbidding 1.2 jog4j and JUL. My point is that we 
need to add the new packages there. See file "solr.txt" under 
lucene/tools/forbiddenApis

> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
> ----------------------------------------------------------------
>
>                 Key: SOLR-7887
>                 URL: https://issues.apache.org/jira/browse/SOLR-7887
>             Project: Solr
>          Issue Type: Task
>            Reporter: Shawn Heisey
>            Assignee: Erick Erickson
>            Priority: Major
>             Fix For: 7.4
>
>         Attachments: SOLR-7887-WIP.patch, SOLR-7887-eoe-review.patch, 
> SOLR-7887-eoe-review.patch, SOLR-7887-followup_1.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, 
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch
>
>
> The logging services project has officially announced the EOL of log4j 1:
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> In the official binary jetty deployment, we use use log4j 1.2 as our final 
> logging destination, so the admin UI has a log watcher that actually uses 
> log4j and java.util.logging classes.  That will need to be extended to add 
> log4j2.  I think that might be the largest pain point to this upgrade.
> There is some crossover between log4j2 and slf4j.  Figuring out exactly which 
> jars need to be in the lib/ext directory will take some research.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to