[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408001#comment-16408001
]
David Smiley commented on SOLR-11913:
-------------------------------------
1. When uploading updated patches, please use an identical filename. JIRA
tracks revisions provided that the file name hasn't changed.
2. I suspect your latest patch won't compile. I see SolrParams now implements
Iterable (great), but in doing so you must provide an implementation of the
{{iterator}} method, which you didn't. Though you did provide a method
{{getMapEntryIteretor}} which should be renamed to {{iterator}}.
3.
bq. But there are other classes too which extend SolrParams and need to be
modified.
_Only_ subclasses of SolrParams that can offer a more efficient implementation
should override the default implementation you are adding to SolrParams.
You'll hopefully realize this as you progress.
> SolrParams ought to implement Iterable<Map.Entry<String,String[]>>
> ------------------------------------------------------------------
>
> Key: SOLR-11913
> URL: https://issues.apache.org/jira/browse/SOLR-11913
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Priority: Minor
> Labels: newdev
> Attachments: SOLR-11913.patch, SOLR-11913_v2.patch
>
>
> SolrJ ought to implement {{Iterable<Map.Entry<String,String[]>>}} so that
> it's easier to iterate on it, either using Java 5 for-each style, or Java 8
> streams. The implementation on ModifiableSolrParams can delegate through to
> the underlying LinkedHashMap entry set. The default impl can produce a
> Map.Entry with a getValue that calls through to getParams.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
