Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/335#discussion_r173637697
--- Diff:
solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java ---
@@ -238,51 +239,52 @@ public void testModifyMetadataV2() throws Exception {
checkFooAndBarMeta(aliasName, zkStateReader);
}
- public void testModifyMetadataV1() throws Exception {
+ @Test
+ public void testModifyPropertiesV1() throws Exception {
// note we don't use TZ in this test, thus it's UTC
final String aliasName = getTestName();
ZkStateReader zkStateReader = createColectionsAndAlias(aliasName);
final String baseUrl =
cluster.getRandomJetty(random()).getBaseUrl().toString();
- HttpGet get = new HttpGet(baseUrl +
"/admin/collections?action=MODIFYALIAS" +
+ HttpGet get = new HttpGet(baseUrl +
"/admin/collections?action=ALIASPROP" +
"&wt=xml" +
"&name=" + aliasName +
- "&metadata.foo=baz" +
- "&metadata.bar=bam");
+ "&properties.foo=baz" +
--- End diff --
I think we want the V1 API prefix for this to be "property" since each
param occurrence is one property by itself. This is consistent with various
other V1 APIs (See CollectionApiMapping.java search for "property"). (My
comment here applies to many spots in the diff, not just here of course).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
