[ 
https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391189#comment-16391189
 ] 

Nathan Gass commented on LUCENE-8038:
-------------------------------------

With my current test setup (elasticsearch 6.2.2 and delimited_payload filter), 
the provided PayloadDecoder.FLOAT_DECODER did not work correctly. I had to 
provide my own looking like this `payload-> payload == null ? 1 : 
PayloadHelper.decodeFloat(payload.bytes, payload.offset)`.

I didn't  look further into it and am therefore not  sure  what the exact 
problem is.

 

> Decouple payload decoding from Similarity
> -----------------------------------------
>
>                 Key: LUCENE-8038
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8038
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>             Fix For: 7.2
>
>         Attachments: LUCENE-8038-master.patch, LUCENE-8038.patch
>
>
> PayloadScoreQuery is the only place that currently uses 
> SimScorer.computePayloadFactor(), and as discussed on LUCENE-8014, this seems 
> like the wrong place for it.  We should instead add a PayloadDecoder 
> abstraction that is passed to PayloadScoreQuery.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to