Hi, I agree with Dawid. By default e.g. Jenkins Slave and also TortoiseGit on Windows don't set windows file endings by default. You have to enable it in the config or the installation program.
Currently the Lucene build system has some SVN relics in it. If you recreate the autogenerated files (like javacc,...) We currently apply local line endings. On the other hand for the checksums we changed to Linux endings. My proposal ist to review all code that regenerates committable files and change the crlf ant task to use Unix line endings. Currently regenerating files is a mess for me. If some committees want windows line endings we can add a ant property that defaults to Unix and is used by all fixcrlf tasks for regenerating stuff. People that have a git installed that uses Windows endings can then put a lot in their home for to configure it. In the same way like they configure git. It must just be in line. Should I open an issue, I started to do that in some other branch already after the last Desaster with autogenerated files. Uwe Am March 3, 2018 4:51:47 PM UTC schrieb Dawid Weiss <[email protected]>: >> Lots of people on Windows use programs like Notepad for "serious" >work. > >This is not an argument for me. Using broken tools is not an excuse. >There > are many excellent text editors for Windows (in fact, I haven't been >able to find an editor >seriously competing with EmEditor in either Linux or Mac world when >handling very >large files). EmEditor is commercial, but there are lots of excellent >open source alternatives >(JEdit, notepad++). > >If you're using notepad for development you can't be seriously a >Windows user... you wouldn't get any >work done at all. > >> If the source control system didn't convert line endings, we would >have >> many complaints from Windows users who double-click on files like >> CHANGES.txt and can't easily read it because the formatting's all >> screwed up, and from people who want to use the text editor built >into >> their OS for editing source code. > >I disagree. You need to know and respect your audience, but you also >have the right to say what you expect. >Source code-level access is for developers. If they're able to check >out the source code using git and compile it then >we must be able to assume they have enough technical knowledge to >figure out opening a text file with notepad is a >bad idea. > >Otherwise, by similar argument, we should distribute two binary >releases -- one for \n systems and >the other for \r\n just so that people can read the txt files with >installation instructions. This isn't sane. > >I don't know why git even has this "facility" of converting line >endings, this is just asking for trouble. Marking a perfectly valid >text file as binary is a bad idea (for example, changes to binary >files are not listed in diffs). > >Dawid > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [email protected] >For additional commands, e-mail: [email protected] -- Uwe Schindler Achterdiek 19, 28357 Bremen https://www.thetaphi.de
