Hi,

 

You should configure GIT to use UNIX line endings. That’s what I have in mind. 
Otherwise precommit works fine on Windows. No idea what you problem could be.

 

Uwe

 

-----

Uwe Schindler

Achterdiek 19, D-28357 Bremen

http://www.thetaphi.de <http://www.thetaphi.de/> 

eMail: [email protected]

 

From: Karl Wright [mailto:[email protected]] 
Sent: Friday, March 2, 2018 2:51 PM
To: Lucene/Solr dev <[email protected]>
Cc: Ignacio Vera <[email protected]>
Subject: Re: ivy-versions broken in e3032dd3fcc

 

ant precommit is usually broken on windows whenever I try to run it, usually 
because of some failure checking Solr doc sources.

 

I raised this issue a few months back and it got fixed briefly but only very 
briefly.  ant precommit is essentially not an option for Windows developers at 
this time.

 

Karl

 

 

On Fri, Mar 2, 2018 at 5:47 AM, Ignacio Vera Sequeiros <[email protected] 
<mailto:[email protected]> > wrote:

Sorry about that!

 

It is fixed now.  

 

I am pushing the commit from a windows machine and ant precommit is broken on 
windows. I did something silly when moving the patch to this computer.

 

I surely need to improve this procedure! :)

 

 

  _____  

From: Dawid Weiss <[email protected] <mailto:[email protected]> >
Sent: Friday, March 2, 2018 10:55:57 AM
To: [email protected] <mailto:[email protected]> ; Ignacio Vera
Subject: ivy-versions broken in e3032dd3fcc 

 

Ignacio, I think you broke ivy-versions on master with your latest
commit. I'd fix it, but for some reasons branch_7x seems to be fine so
it wasn't a cherry pick -- please see into it (and run ant precommit
before you push! :).

D.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] 
<mailto:[email protected]> 
For additional commands, e-mail: [email protected] 
<mailto:[email protected]> 

 

Reply via email to