[
https://issues.apache.org/jira/browse/SOLR-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373055#comment-16373055
]
Joel Bernstein edited comment on SOLR-7798 at 2/22/18 4:47 PM:
---------------------------------------------------------------
Just getting reacquainted with the code. I believe the 200 magic number is an
inflection point for when it makes sense to build a disjunction query for
retrieving the group records. I did quite a bit of performance tuning in the
original release and I believe 200 was the tipping point for when the
disjunction slowed things down, rather then sped things up. I'll need to do a
little more digging to fully understand how the patch effects things.
was (Author: joel.bernstein):
Just getting reacquainted with the code. I believe the 200 magic number is an
inflection point for when it makes sense to build a disjunction query for
retrieving the group records. I'll need to do a little more digging to fully
understand how the patch effects things.
> Improve robustness of ExpandComponent
> -------------------------------------
>
> Key: SOLR-7798
> URL: https://issues.apache.org/jira/browse/SOLR-7798
> Project: Solr
> Issue Type: Improvement
> Components: SearchComponents - other
> Reporter: Jörg Rathlev
> Assignee: Joel Bernstein
> Priority: Minor
> Attachments: expand-component.patch, expand-npe.patch
>
>
> The {{ExpandComponent}} causes a {{NullPointerException}} if accidentally
> used without prior collapsing of results.
> If there are multiple documents in the result which have the same term value
> in the expand field, the size of the {{ordBytes}}/{{groupSet}} differs from
> the {{count}} value, and the {{getGroupQuery}} method creates an incompletely
> filled {{bytesRef}} array, which later causes a {{NullPointerException}} when
> trying to sort the terms.
> The attached patch extends the test to demonstrate the error, and modifies
> the {{getGroupQuery}} methods to create the array based on the size of the
> input maps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
