[
https://issues.apache.org/jira/browse/SOLR-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372286#comment-16372286
]
Erick Erickson commented on SOLR-10809:
---------------------------------------
This is getting closer. I ran into some issues on this latest go-round, and I'd
particularly like [~joel.bernstein][~risdenk][~dpgove] and [~covolution] to
weigh in. Basically, a number of the close operations on streams had to have
null checks included to pass the tests. That part seems fairly safe. I didn't
go very far into trying to figure out _how_ these are null when close is
called, as I mentioned earlier I'm trying mightily to not rewrite too much.
However, StreamExpressionToExpressionTest.testTopicStream still fails. The root
of the issue is that TopicStream.close() calls
TopicStream.persistCheckpoints(), which fails in this try block because
cloudSolrClient is null. This is about line 469 in my code.
try {
cloudSolrClient.request(request);
.
.
.
}
Is it as simple as returning from persistCheckpoints if cloudSolrClient is null
and is that reasonable? If so, I'll make that happen.
I also changed the following any comments you have welcome.
FeaturesSelectionStream
TopicStream
DeamonStream
FacetStream
FeaturesSelectionStream
TextLogitStream
TopicStream
StreamExpressionTest
StreamExpressionToExplanationTest
StreamingTest
TestJavabinTupleStreamParser
> Get precommit lint warnings out of Solr core
> --------------------------------------------
>
> Key: SOLR-10809
> URL: https://issues.apache.org/jira/browse/SOLR-10809
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-10809.patch, SOLR-10809.patch
>
>
> Changing to fit "the new paradigm" of de-linting a directory at a time. I
> hope to get precommit to fail on precommit warnings from some point on down
> the tree, and solr/core is the first unit I've been working on.
> I'll have a patch soon.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
