Github user slackhappy commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/321#discussion_r166183887
--- Diff: solr/core/src/java/org/apache/solr/cloud/Overseer.java ---
@@ -303,7 +303,7 @@ private void checkIfIamStillLeader() {
String path = OVERSEER_ELECT + "/leader";
byte[] data;
try {
- data = zkClient.getData(path, null, stat, true);
+ data = zkClient.getData(path, null, stat, false);
--- End diff --
i changed the `retryOnConnLoss` to false here because
`checkIfIamStillLeader` is the teardown hook. The retry was causing tests to
fail due to the com.carrotsearch.randomizedtesting.ThreadLeakControl check
seeing threads that were waiting on retry, and also, it seems a little weird to
do this retrying on a teardown hook anyway.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
