[
https://issues.apache.org/jira/browse/SOLR-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321269#comment-16321269
]
Varun Thacker commented on SOLR-11718:
--------------------------------------
Hi Amrit,
Thanks for picking up this Jira
Few questions while looking at the patch
1. In CdcrRequestHandlerTest#testCheckpointActions why have the asserts been
commented out?
2. "Since the CdcrReplicationHandlerTest was failing, suggesting typical Index
Replication will take place when followers are numRecordsToKeep count behind."
- Maybe we should modify the test to assert document count instead of just
commenting it out?
3. I don't quite understand the doc changes - "ENABLEBUFFER API has been
deprecated in favor of when buffering is enabled, the Update Logs will grow
without limit; they will never be purged."
> Deprecate CDCR Buffer APIs
> --------------------------
>
> Key: SOLR-11718
> URL: https://issues.apache.org/jira/browse/SOLR-11718
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: CDCR
> Affects Versions: 7.1
> Reporter: Amrit Sarkar
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11718.patch, SOLR-11718.patch
>
>
> Kindly see the discussion on SOLR-11652.
> Today, if we see the current CDCR documentation page, buffering is "disabled"
> by default in both source and target. We don't see any purpose served by Cdcr
> buffering and it is quite an overhead considering it can take a lot heap
> space (tlogs ptr) and forever retention of tlogs on the disk when enabled.
> Also today, even if we disable buffer from API on source , considering it was
> enabled at startup, tlogs are never purged on leader node of shards of
> source, refer jira: SOLR-11652
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
