[
https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288706#comment-16288706
]
David Smiley commented on LUCENE-8086:
--------------------------------------
[~daddywri] and [~ivera] I'm looking at GeoCircleFactory and GeoStandardCircle
and GeoExactCircle. Try to put yourself into a user's shoes who has no idea
which to choose. Note that both circles have the same class javadocs (albeit
not "public"). Also note that both factory methods on GeoCircleFactory look
similar. So I've been following these issues loosely and have some vague idea
of what's going on. I think it's weird that GeoExactCircle is named as such
which, by it's name, might suggest (to me) that any other circle isn't "exact".
Yet AFAICT this isn't true and in fact is the opposite! GeoStandardCircle is
accurate in spherical, and GeoExactCircle, despite it's name, is an
approximation with configurable error for non-spherical.
Sure some more/better javadocs would help but I have to wonder if we need to
express the distinction publicly. That is... if the PlanetModel passed is a
sphere, then use GeoStandardCircle, and if it isn't, use GeoExactCircle.
Essentially with this I'm suggesting moving the change in this patch in
Geo3dShapeFactory (Spatial4j abstraction) to GeoCircleFactory (down a layer of
abstraction). WDYT?
> G3d wrapper: Improve circles for non spherical planets
> ------------------------------------------------------
>
> Key: LUCENE-8086
> URL: https://issues.apache.org/jira/browse/LUCENE-8086
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Ignacio Vera
>
> Hi [~dsmiley],
> The purpose of this ticket is to add a new circle shape (GeoExactCircle) for
> non-spherical planets and therefore remove the method relate from
> Geo3dCircleShape. The patch will include some simplifications on the wrapper
> and some refactoring of the tests.
> I will open shortly a pull request.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
