Github user jpountz commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/280#discussion_r155453742
  
    --- Diff: 
lucene/core/src/java/org/apache/lucene/search/similarities/AfterEffectL.java ---
    @@ -34,11 +34,14 @@ public final double score(BasicStats stats, double tfn) 
{
       }
       
       @Override
    +  // TODO: add explanation for tfn
    +  // Currently not possible, as CheckHits.verifyExplanation fails because
    +  // in case of a single sub-expl the test expects
    +  // the sub-expl's score to be equal to the parent expl's score
    --- End diff --
    
    this should be possible by rebasing or merging master back, I modified 
CheckHits yesterday so that it allows the score to be different from the parent 
explanation if the explanation matches `.*, computed as .* from:`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to