[
https://issues.apache.org/jira/browse/SOLR-11597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238411#comment-16238411
]
Christine Poerschke commented on SOLR-11597:
--------------------------------------------
Hello Michael, thank you for opening this ticket with a pull request!
I will add your tutorial and the icml_ranking.pdf paper to my reading list :-)
In the meantime, here's some quick thoughts from a quick look at the pull
request:
* Great class-level javadocs. Let's also add the new class to the table in the
Solr Reference Guide the source for which is now in the same git repo as the
code i.e.
https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/src/learning-to-rank.adoc
* Curiosity only at this point, not yet having read your tutorial or the paper:
{code}
"weights" : [
"1,2,3\n4,5,6\n7,8,9\n10,11,12",
"13,14,15,16\n17,18,19,20",
"21,22"
]
{code}
representation versus (say)
{code}
"weights" : [
[ [ 1, 2, 3 ], [ 4, 5, 6 ], [ 7, 8, 9 ], [ 10, 11, 12 ] ],
[ [ 13, 14, 15, 16 ], [ 17, 18, 19, 20 ] ],
[ [ 21, 22 ] ]
]
{code}
* How about implementing/overriding the {{validate}} method? E.g. if for the
non-linearity parameter someone mistypes "sigmoidt" instead of "sigmoid" then
the validate method could right away through a model exception instead of the
doNonlinearity method later on being a no-op which could be tricky to debug
from a user's perspective.
* Something probably already on your todo list and/or something which others in
the community might be interested in collaborating on: test coverage of some
sort, possibly but not necessarily similar to the existing TestLinearModel and
TestMultipleAdditiveTreesModel tests
* minor thing: I'm pretty sure the {{String.format("...", ...);}} in the
explain method will be flagged up by the forbidden-apis checks in {{ant
precommit}} pointing towards {{String.format(Locale.???, "...", ...)}} as the
alternative. Related link:
https://github.com/policeman-tools/forbidden-apis/blob/master/src/main/resources/de/thetaphi/forbiddenapis/signatures/jdk-unsafe-1.6.txt#L48
> Implement RankNet.
> ------------------
>
> Key: SOLR-11597
> URL: https://issues.apache.org/jira/browse/SOLR-11597
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
> Reporter: Michael A. Alcorn
> Priority: Normal
>
> Implement RankNet as described in [this
> tutorial|https://github.com/airalcorn2/Solr-LTR].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
