[ 
https://issues.apache.org/jira/browse/SOLR-11054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124489#comment-16124489
 ] 

Cao Manh Dat commented on SOLR-11054:
-------------------------------------

According to my understanding about AutoCommitTest and SoftAutoCommitTest, the 
source of AutoCommitTest failure belong to its NewSearcherListener, 
SoftAutoCommitTest with better listener won't meet the same problem. Therefore 
we can include searchability in the test in a reliable way.

You're right about whether we should adding searchability in our test or not. 
Yes we don't have to. But from my point of view, we will feel much confident 
when remove AutoCommitTest.testMaxDocs() if testSoftAndHardCommitMaxDocs() test 
the same thing, right?

> Add SoftAutoCommitTest.testSoftAndHardCommitMaxDocs
> ---------------------------------------------------
>
>                 Key: SOLR-11054
>                 URL: https://issues.apache.org/jira/browse/SOLR-11054
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>         Attachments: SOLR-11054.patch, SOLR-11054.patch
>
>
> SoftAutoCommitTest should have a testSoftAndHardCommitMaxDocs that checks the 
> maxDocs option for autocommit using the same monitor polling used by other 
> existing SoftAutoCommitTest tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to