[
https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112638#comment-16112638
]
Karl Wright commented on LUCENE-7906:
-------------------------------------
Hi [~ivera], I tried folding your patch into my workarea and running the
standard "ant test" on it.
(1) I got 20 warnings that look like we should fix them:
{code}
[javac] ^
[javac]
C:\wipgit\lucene4\lucene-solr\lucene\spatial3d\src\test\org\apache\lucene\spatial3d\geom\RandomGeoShapeRelationshipTest.java:131:
warning: auxiliary class Constraints in
C:\wipgit\lucene4\lucene-solr\lucene\spatial3d\src\test\org\apache\lucene\spatial3d\geom\RandomGeoShapeGenerator.java
should not be accessed from outside its own source file
[javac] constraints = new Constraints();
[javac] ^
{code}
The new test RandomGeoShapeRelationshipTest takes too long to run (5 minutes)
for normal consumption. Usually tests have a certain relatively small number
of iterations but we run them multiple times through the process known as
"beasting". For example:
{code}
ant beast -Dbeast.iters=100 -Dtestcase=TestGeo3DPoint
-Dtestmethod=testRandomMedium -Dtests.dups=6 -Dtests.iters=10
{code}
Can you reduce the number of internal iterations that test does? Or better
yet, point me at where I'd do that? Thanks!
> Spatial relationship between Geoshapes
> --------------------------------------
>
> Key: LUCENE-7906
> URL: https://issues.apache.org/jira/browse/LUCENE-7906
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Attachments: LUCENE-7906-AreaShape.patch, LUCENE-7906.patch
>
>
> Hi,
> Working with geosahpes and trying to resolve spatial relationships between
> them I came accross a big limitation when trying to solve the relationship
> between two geopolygons. This object does not expose the internal structure.
> In particular at some point, it is necessary to check if one polygon
> intersects the edges of the other polygon which currently is not possible as
> edges are not exposed.
> To be able to perform such operation it can be several options. The ones I
> can think of are:
> 1) Expose the edges of the polygon ( and probably the notable points for the
> edges) adding getters in the GeoPolygon interface. Easy to implement and
> leave users the responsability of coding the spatial relationship.
> 2) Extends GeoPolygon interface to extends geoarea and leave the object make
> the spatial relationship.
> 3) Extends GeoShape interface so all shapes can infer the spatial
> relationship with other GeoShapes.
> I might be bias as my interest is in 2d Shapes in the unit sphere and there
> might be some cases which what I propose cannot be implemented or are againts
> the aim of the library.
> What do you think?
> Cheers,
> Ignacio
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
