[
https://issues.apache.org/jira/browse/SOLR-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106277#comment-16106277
]
Amrit Sarkar commented on SOLR-10734:
-------------------------------------
Ishan,
{quote}
Given that the tests or the implementation itself is broken, should we add an
experimental annotation to the URP?
{quote}
I firmly believe the implementation is still intact, i.e. not all the threads
will get successfully executed, there's no guarantee for it. The tests,
{{testMultipleThreads}} still doesn't take that into perspective, which
increasing the attempts and lowering the test wouldn't fix either.
{quote}
I can confirm that this test fails almost 9 out of 10 times on my box (when
running with -Dtests.jvms=12).
{quote}
After the patch recently uploaded, where {{exact match}} is changed to
{{range}}. if I run {{ant -Dtestcase=AtomicUpdateProcessorFactoryTest
-Dtests.jvms=12 test}} on 8GB RAM, 256GB storage SSD Mac, it ran fine for me
for multiple times. I am not sure how else to cope this.
> Multithreaded test/support for AtomicURP broken
> -----------------------------------------------
>
> Key: SOLR-10734
> URL: https://issues.apache.org/jira/browse/SOLR-10734
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
> Assignee: Noble Paul
> Fix For: master (8.0), 7.1
>
> Attachments: log-snippet, Screen Shot 2017-05-31 at 4.50.23 PM.png,
> SOLR-10734.patch, SOLR-10734.patch
>
>
> The multithreaded test doesn't actually start the threads, but only invokes
> the run directly. The join afterwards doesn't do anything, hence.
> {code}
> diff --git
> a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
>
> b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
> index f3f833d..10b7770 100644
> ---
> a/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
> +++
> b/solr/core/src/test/org/apache/solr/update/processor/AtomicUpdateProcessorFactoryTest.java
> @@ -238,7 +238,7 @@ public class AtomicUpdateProcessorFactoryTest extends
> SolrTestCaseJ4 {
> }
> }
> };
> - t.run();
> + t.run(); // red flag, shouldn't this be t.start?
> threads.add(t);
> finalCount += index; //int_i
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
