[
https://issues.apache.org/jira/browse/LUCENE-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094674#comment-16094674
]
Karl Wright commented on LUCENE-7906:
-------------------------------------
[~ivera], I had a quick glance at the newer patch. So far, so good, but have a
care for spelling and for code style. Have a look here:
{code}
+ private boolean instersectsEdge(GeoShape other,Edge currentEdge,Edge
firstEdge){
+ if (currentEdge == firstEdge){
+ return false;
+ }
+ if
(other.intersects(currentEdge.plane,currentEdge.notablePoints,currentEdge.startPlane,currentEdge.endPlane))
{
+ return true;
+ }
+ if (firstEdge == null){
+ firstEdge = currentEdge;
+ }
+ return instersectsEdge(other,currentEdge.next,firstEdge);
+ }
{code}
First note: "instersectsEdge" is misspelled; let's fix that before proceeding
to commit.
Second, the style guide for Lucene states that there's a space after commas in
argument lists for methods.
Minor details, but important. I'll have a longer look this evening.
> Spatial relationship between Geoshapes
> --------------------------------------
>
> Key: LUCENE-7906
> URL: https://issues.apache.org/jira/browse/LUCENE-7906
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial3d
> Reporter: Ignacio Vera
> Assignee: Karl Wright
> Attachments: LUCENE-7906.patch
>
>
> Hi,
> Working with geosahpes and trying to resolve spatial relationships between
> them I came accross a big limitation when trying to solve the relationship
> between two geopolygons. This object does not expose the internal structure.
> In particular at some point, it is necessary to check if one polygon
> intersects the edges of the other polygon which currently is not possible as
> edges are not exposed.
> To be able to perform such operation it can be several options. The ones I
> can think of are:
> 1) Expose the edges of the polygon ( and probably the notable points for the
> edges) adding getters in the GeoPolygon interface. Easy to implement and
> leave users the responsability of coding the spatial relationship.
> 2) Extends GeoPolygon interface to extends geoarea and leave the object make
> the spatial relationship.
> 3) Extends GeoShape interface so all shapes can infer the spatial
> relationship with other GeoShapes.
> I might be bias as my interest is in 2d Shapes in the unit sphere and there
> might be some cases which what I propose cannot be implemented or are againts
> the aim of the library.
> What do you think?
> Cheers,
> Ignacio
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
