[
https://issues.apache.org/jira/browse/SOLR-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080462#comment-16080462
]
Anshum Gupta commented on SOLR-10452:
-------------------------------------
[~gerlowskija] I just glanced through it and don't think we should move the
queryParams to the builder. Anything that needs flexibility post-construction
i.e. might need to be changed post construction of the client shouldn't be part
of the builder. Let me know if you think otherwise.
> setQueryParams should be deprecated in favor of SolrClientBuilder methods
> -------------------------------------------------------------------------
>
> Key: SOLR-10452
> URL: https://issues.apache.org/jira/browse/SOLR-10452
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Priority: Minor
> Fix For: 7.0
>
> Attachments: SOLR-10452.patch
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each
> {{SolrClient}} can be deprecated, and their functionality moved over to the
> Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice
> to have all the knobs, and levers used to tweak {{SolrClient}}s available in
> a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are
> mutable. Using some {{SolrClient}} setters can result in erratic and "trappy"
> behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setQueryParams}}
> setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
