[
https://issues.apache.org/jira/browse/SOLR-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069567#comment-16069567
]
ASF subversion and git services commented on SOLR-1095:
-------------------------------------------------------
Commit 196d84b9e08730e9af225450217032cf70d52b5a in lucene-solr's branch
refs/heads/master from [~noble.paul]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=196d84b ]
SOLR-1095: Refactor code to standardize replica assignment
> StopFilterFactory should not use HashSet
> ----------------------------------------
>
> Key: SOLR-1095
> URL: https://issues.apache.org/jira/browse/SOLR-1095
> Project: Solr
> Issue Type: Bug
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Critical
> Fix For: 1.4
>
> Attachments: SOLR-1095.patch
>
>
> Rev 680935 of StopFilterFactory introduced some changes that can cause poor
> performance do to the use of HashSet instead of CharArraySet in the inform()
> method. I noticed this while profiling
> http://www.lucidimagination.com/search/document/f46f0edfc439356c/solr_user_upgrade_from_1_2_to_1_3_gives_3x_slowdown
> whereby 20% of the time spent in indexing occurred in Collections.addAll()
> in the Lucene StopFilter due to the execution of the else clause in the lines:
> {code}
> if (stopWords instanceof CharArraySet) {
> this.stopWords = (CharArraySet)stopWords;
> } else {
> this.stopWords = new CharArraySet(stopWords.size(), ignoreCase);
> this.stopWords.addAll(stopWords);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
