[
https://issues.apache.org/jira/browse/SOLR-10779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053496#comment-16053496
]
ASF subversion and git services commented on SOLR-10779:
--------------------------------------------------------
Commit 64093d6df10a426551a0aeb4c157f9e05e5bf7bf in lucene-solr's branch
refs/heads/master from Erick
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=64093d6 ]
SOLR:10779: JavaBinCodec should use close consistently rather than having
marshal() and close() call finish() (which closes the underlying stream)
commit b31178e0c33dbfe81fbc1aec705b3dae3cc895ad
Author: Erick <[email protected]>
Date: Sun Jun 18 22:34:21 2017 -0700
SOLR-10779: JavaBinCodec should use close consistently rather than having
marshal() and close() call finish() (which closes the underlying stream)
> JavaBinCodec should use close consistently rather than having marshal() and
> close() call finish() (which closes the underlying stream)
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-10779
> URL: https://issues.apache.org/jira/browse/SOLR-10779
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-10779.patch, SOLR-10779.patch, SOLR-10779.patch
>
>
> Having the marshal() code call finish which in turn calls close() is trappy.
> The marshal code is not robust anyway since if there's an exception before
> the try loop, it will not close the resource.
> Sub task of SOLR-10778
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
