[
https://issues.apache.org/jira/browse/SOLR-10907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052216#comment-16052216
]
Erick Erickson commented on SOLR-10907:
---------------------------------------
Yep, sure does seem simple. But that's the exact pattern I've followed many
times in my soon-to-be-committed-I-promise patch for JavaBinCodec. What I
suspect has happened is a number of those classes didn't implement Closeable
when they were first written/used but did later. In fact JavaBinCodec didn't
implement Closeable in 6.3 for instance but does now.
I'm also thinking of only putting any of these in master/7.0, I think there's
potential to introduce subtle bugs here and don't think it adds enough value to
push into 6x given that we've lived with these warnings for a long time. Up to
individuals of course.
> fix Resource Leak warning in ExpandComponent
> --------------------------------------------
>
> Key: SOLR-10907
> URL: https://issues.apache.org/jira/browse/SOLR-10907
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: clients - java
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-10907.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
