[ 
https://issues.apache.org/jira/browse/SOLR-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16046570#comment-16046570
 ] 

Shalin Shekhar Mangar commented on SOLR-10867:
----------------------------------------------

I see a test failure in your logs because of which the resources are not being 
correctly released:
{code}
   [junit4] ERROR   0.03s | 
ClassificationUpdateProcessorFactoryTest.init_fullArgs_shouldInitFullClassificationParams
 <<<
   [junit4]    > Throwable #1: org.apache.solr.common.SolrException: 
Classification UpdateProcessor 'classField' can not be null
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([72930463E0C8A2F7:A71DC99A39853BE1]:0)
   [junit4]    >        at 
org.apache.solr.update.processor.ClassificationUpdateProcessorFactory.checkNotNull(ClassificationUpdateProcessorFactory.java:115)
   [junit4]    >        at 
org.apache.solr.update.processor.ClassificationUpdateProcessorFactory.populateParams(ClassificationUpdateProcessorFactory.java:137)
   [junit4]    >        at 
org.apache.solr.update.processor.ClassificationUpdateProcessorFactory.getInstance(ClassificationUpdateProcessorFactory.java:225)
   [junit4]    >        at 
org.apache.solr.update.processor.ClassificationUpdateProcessorFactoryTest.init_fullArgs_shouldInitFullClassificationParams(ClassificationUpdateProcessorFactoryTest.java:86)
{code}

> Make ClassificationUpdateProcessorFactory as Runtime URP; take params(s) with 
> request
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-10867
>                 URL: https://issues.apache.org/jira/browse/SOLR-10867
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: update
>            Reporter: Amrit Sarkar
>            Priority: Minor
>         Attachments: error, SOLR-10867.patch, SOLR-10867.patch, 
> SOLR-10867.patch
>
>
> We are trying to get rid of processor definitions in SolrConfig for all URPs 
> and take parameters in the request itself.
> ClassificationUpdateProcessorFactory will be able to execute by sample curl 
> like below:
> {code}
> curl -X POST -H Content-Type: application/json  
> http://localhost:8983/solr/test/update/json/docs?processor=Classification&classification.fieldName=url_s&classification.classField=training&commit=true
>  --data-binary { "id" : "1" , "url_s" : "http://www.example.com/subroot"; }
> {code}
> All the param(s) for this URP available can be passed as request handler 
> param(s).
> Configuration for ClassificationUpdateProcessorFactory in solrconfig.xml is 
> optional.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to