Hoss Man created SOLR-10864:
-------------------------------
Summary: Add static (test only) boolean to PointField indicating
'precisionStep' should be ignored
Key: SOLR-10864
URL: https://issues.apache.org/jira/browse/SOLR-10864
Project: Solr
Issue Type: Sub-task
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Hoss Man
Assignee: Hoss Man
(I'm spinning this idea out of parent jira SOLR-10807 so that it gets it's own
jira# w/ it's own summary for increased visibility/comments)
In the interest of making it easier & more straight forward to get good
randomized test coverage of Points fields, I'd like to add the following to the
{{PointField}} class...
{code}
/**
* <p>
* The Test framework can set this global variable to instruct PointField that
* (on init) it should be tollerant of the <code>precisionStep</code> argument
used by TrieFields.
* This allows for simple randomization of TrieFields and PointFields w/o
extensive duplication
* of <code><fieldType/></code> declarations.
* </p>
*
* <p>NOTE: When {@link TrieField} is removed, this boolean must also be
removed</p>
*
* @lucene.internal
* @lucene.experimental
*/
public static boolean TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS = false;
/**
* NOTE: This method can be removed completely when
* {@link #TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS} is removed
*/
@Override
protected void init(IndexSchema schema, Map<String, String> args) {
super.init(schema, args);
if (TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS) {
args.remove("precisionStep");
}
}
{code}
Then in SolrTestCaseJ4, set
{{PointField.TEST_HACK_IGNORE_USELESS_TRIEFIELD_ARGS}} on a class by class
basis when randomizing Trie/Points (and unset \@AfterClass).
(details to follow in comment)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
