[
https://issues.apache.org/jira/browse/SOLR-10703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041304#comment-16041304
]
ASF GitHub Bot commented on SOLR-10703:
---------------------------------------
Github user diegoceccarelli commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/202#discussion_r120698740
--- Diff: solr/core/src/java/org/apache/solr/response/DocsStreamer.java ---
@@ -142,6 +142,11 @@ public boolean hasNext() {
return docIterator.hasNext();
}
+ // called at the end of the stream
--- End diff --
the reason for `prepare` and `finish` was to have the same naming of
components, imo it makes easier to understand what's going on, I do like the
Closeable idea, do you think it would be better?
> Also, line 89 still calls setContext() .. is it right? or I'm missing
something?
No, I missed line 89, thank you
> Add prepare() and finish() into DocTransformer
> -----------------------------------------------
>
> Key: SOLR-10703
> URL: https://issues.apache.org/jira/browse/SOLR-10703
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Diego Ceccarelli
> Priority: Minor
> Fix For: master (7.0)
>
>
> This patch adds a {{prepare}} and a {{finish}} method to the interface of
> {{DocTransformer}} allowing a developer to perform actions before/after a doc
> transformer is applied to a result set. My use case was to benchmark the
> performance of a transformer, since transformer time is not part of
> {{QTime}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
