Github user cpoerschke commented on the issue:

    https://github.com/apache/lucene-solr/pull/189
  
    Hi Judith - thanks for adding me to the collaborator list. I've added one 
more commit to the https://github.com/jitka18/lucene-solr/pull/1 request and 
would suggest something along the following lines as the next steps:
    * to review https://github.com/jitka18/lucene-solr/pull/1 and if it looks 
good merge it into your jira/solr-6203 branch and/or add comments on the pull 
request
    * to merge the latest master (at the time) into the jira/solr-6203 working 
branch
    ** this will give some merge conflicts that need to be resolved
    ** this will somewhat reduce the scope and complexity of the changes for 
the working branch since SOLR-10394 part-2 renames will be picked up from the 
latest master
    * to see if new code duplication in DistributedQueryComponentCustomSortTest 
can be reduced further, this will not just reduce the amount of code but will 
(i think) also help with clarity i.e. what is being tested
    
    How does that sound? Any questions, please let me know. - Christine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to