[
https://issues.apache.org/jira/browse/SOLR-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961852#comment-15961852
]
ASF GitHub Bot commented on SOLR-10415:
---------------------------------------
GitHub user michaelbraun opened a pull request:
https://github.com/apache/lucene-solr/pull/182
SOLR-10415 - improve debug logging to use parameterized logging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelbraun/lucene-solr
solr-10415-debuglogging
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #182
----
commit faaa3d4d426488c6bffbc4995bad2b45ea5d60f3
Author: Michael Braun <[email protected]>
Date: 2017-04-08T14:45:46Z
SOLR-10415 - improve debug logging to use parameterized logging where
appropriate
----
> Within solr-core, debug/trace level logging should use parameterized log
> messages
> ---------------------------------------------------------------------------------
>
> Key: SOLR-10415
> URL: https://issues.apache.org/jira/browse/SOLR-10415
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Michael Braun
> Priority: Trivial
>
> Noticed in several samplings of an active Solr that several debug statements
> were taking decently measurable time because of the time of the .toString
> even when the log.debug() statement would not output because it was
> effectively INFO or higher. Using parameterized logging statements, ie
> 'log.debug("Blah {}", o)' will avoid incurring that cost.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
