[
https://issues.apache.org/jira/browse/SOLR-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935705#comment-15935705
]
Koji Sekiguchi commented on SOLR-9184:
--------------------------------------
I think this is almost ready. How about adding assertNotSame for the first test?
> Add convenience method to ModifiableSolrParams
> ----------------------------------------------
>
> Key: SOLR-9184
> URL: https://issues.apache.org/jira/browse/SOLR-9184
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: Jörg Rathlev
> Priority: Minor
> Attachments: SOLR-9184.patch
>
>
> Add a static convenience method {{ModifiableSolrParams#of(SolrParams)}} which
> returns the same instance if it already is modifiable, otherwise creates a
> new {{ModifiableSolrParams}} instance.
> Rationale: when writing custom SearchComponents, we find that we often need
> to ensure that the SolrParams are modifiable. The copy constructor of
> ModifiableSolrParams always creates a copy, even if the SolrParms already are
> modifiable.
> Alternatives: The method could also be added as a convenience method in
> SolrParams itself, which already has static helper methods for wrapDefaults
> and wrapAppended.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
