[
https://issues.apache.org/jira/browse/LUCENE-7716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887885#comment-15887885
]
Michael McCandless commented on LUCENE-7716:
--------------------------------------------
+1, except maybe add a message to the {{IllegalArgumentException}}?
> Reduce specialization in TopFieldCollector
> ------------------------------------------
>
> Key: LUCENE-7716
> URL: https://issues.apache.org/jira/browse/LUCENE-7716
> Project: Lucene - Core
> Issue Type: Wish
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-7716.patch
>
>
> TopFieldCollector optimizes the single-comparator case. I think we could
> replace this specialization with a MultiLeafFieldComparator wrapper,
> similarly to how MultiCollector works. This would have the benefit of
> replacing code duplication of non-trivial logic with a simple wrapper that
> delegates calls to its sub comparators.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
