[
https://issues.apache.org/jira/browse/SOLR-10152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877494#comment-15877494
]
David Smiley commented on SOLR-10152:
-------------------------------------
+1 looks fine. Did you contribute this simply because, after having done the
UnifiedHighlighter, doing this was easy since it's almost the same code so
might as well, or do you actually use the PostingsHighlighter over the
UnifiedHighlighter? If the latter I'd like to hear how the UH isn't meeting
your needs. The UnifiedHighlighter is essentially an evolved version of the
PostingsHighlighter.
> PostingsSolrHighlighter support for CustomSeparatorBreakIterator (LUCENE-6485)
> ------------------------------------------------------------------------------
>
> Key: SOLR-10152
> URL: https://issues.apache.org/jira/browse/SOLR-10152
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: highlighter
> Reporter: Amrit Sarkar
> Attachments: SOLR-10152.patch
>
>
> Lucene 5.3 added a CustomSeparatorBreakIterator (see LUCENE-6485)
> SOLR-10152.patch uploaded which incorporates CustomSeparatorBreakIterator in
> PostingsSolrHighlighter.
> - added a new request param option to specify which separator char to use.
> *customSeparatorChar*.
> - changed PostingsSolrHighlighter.getBreakIterator to check
> HighlightParams.BS_TYPE first.
> - if type=='CUSTOM', look for the new separator param, in getBreakIterator,
> validate it's a single char, & skip locale parsing.
> - 'WHOLE' option moved from parseBreakIterator to getBreakIterator, as it
> doesn't depend on locale.
> Changes made in:
> * HighlightParams.java
> * PostingsSolrHighlighter.java
> * test cases added in TestPostingsSolrHighlighter
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
