[
https://issues.apache.org/jira/browse/SOLR-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871482#comment-15871482
]
ASF GitHub Bot commented on SOLR-10134:
---------------------------------------
GitHub user alero opened a pull request:
https://github.com/apache/lucene-solr/pull/158
SOLR-10134 - Support SchemaAPI in EmbeddedSolrServer
Adds support for changing the schema in mutable mode and using
EmbeddedSolrServer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alero/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #158
----
commit 3603832e3d4fdb3bfe3fa9eb27202b71dda4e068
Author: Robert Alexandersson <[email protected]>
Date: 2017-02-16T16:06:20Z
SOLR-10134
Added the httpMethod param to context so SolR SchemaAPI can handle POST
calls
commit 6de410703d0e1be497289017ca1e1c1c4d8303bd
Author: Robert Alexandersson <[email protected]>
Date: 2017-02-17T07:54:43Z
SOLR-10134
Added testcase and enabled the SchemaHandler to parse the incoming command
commit 09559122d445aa4efa4cf9beffa6622120fe5f6f
Author: Robert Alexandersson <[email protected]>
Date: 2017-02-17T07:59:25Z
SOLR-10134
Added testcase and enabled the SchemaHandler to parse the incoming command
commit dc02bcf8de62169dbbe9674c5d5f899c5064e37c
Author: Robert Alexandersson <[email protected]>
Date: 2017-02-17T09:03:00Z
SOLR-10134
Improved the test case and added a failing test for immutable config
----
> EmbeddedSolrServer does not support SchemaAPI
> ---------------------------------------------
>
> Key: SOLR-10134
> URL: https://issues.apache.org/jira/browse/SOLR-10134
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Server, SolrJ
> Affects Versions: 6.4.1
> Reporter: Robert Alexandersson
> Labels: test-driven
> Attachments: SOLR-10134.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The EmbeddedSolrServer server does not support calls to the POST methods of
> SchemaAPI using SolRJ api. The reason is that the httpMethod param is never
> set by the EmbeddedSolrServer#request(SolrRequest, String) and this is later
> required by the SchemaHandler class that actually performs the call at
> SchemaHandler#handleRequestBody(SolrQueryRequest, SolrQueryResponse).
> Proposal is to enhance the EmbeddedSolrServer to forward the httpMethod at
> aprox row 174 with the following: "req.getContext().put("httpMethod",
> request.getMethod().name());". This change requires the Factory methods of
> SolrJ to add the intended method to be used example : new
> SchemaRequest.AddField(....) should append the POST method similar to how the
> SchemaRequest.Field appends the GET method.
> I have written a separate EmbeddedSolrServer that replaces the one in SolR.
> It works for now and fields can be created on the fly using the SchemaAPI of
> the solrj client, but would like to be able to remove this workaround.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
